On 05/10/2016 18:01, Ville Syrjälä wrote:
On Wed, Oct 05, 2016 at 01:33:28PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
unsigned long is too wide - use smaller types in
struct cxsr_latency to save 800-something bytes of .rodata.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
---
drivers/gpu/drm/i915/intel_drv.h | 16 ++++++++--------
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index f48e79ae2ac6..c52b1d3a7ba0 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -807,14 +807,14 @@ struct intel_watermark_params {
};
struct cxsr_latency {
- int is_desktop;
- int is_ddr3;
- unsigned long fsb_freq;
- unsigned long mem_freq;
- unsigned long display_sr;
- unsigned long display_hpll_disable;
- unsigned long cursor_sr;
- unsigned long cursor_hpll_disable;
+ bool is_desktop : 1;
+ bool is_ddr3 : 1;
+ unsigned int fsb_freq;
+ unsigned int mem_freq;
+ unsigned int display_sr;
+ unsigned int display_hpll_disable;
+ unsigned int cursor_sr;
+ unsigned int cursor_hpll_disable;
Am I blind or would all of the values fit even in u16?
No you are right, I'll improve it accordingly. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
