On ke, 2016-10-05 at 17:53 +0100, Tvrtko Ursulin wrote: > On 05/10/2016 17:50, Tvrtko Ursulin wrote: > > > > > > On 05/10/2016 16:07, Joonas Lahtinen wrote: > > > > > > On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: > > > > > > > > From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > > > > > > > Use types of more appropriate size in struct > > > > intel_watermark_params to save 512 bytes of .rodata. > > > > > > > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > > > The code does seem to use datatypes very sloppily. Where did you > > > pick > > > up these? > > > > I was just nosing around in .rodata and wondered why a huge table > > of > > zeros. :) > > > > Oops no, that was the cxsr table which stood out so much. After I > found > that one I nosed around some more to see which ones look wasteful. > I rather meant how did you deduce the right datatype sizes? Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
