On ti, 2016-09-27 at 10:44 +0100, Tvrtko Ursulin wrote: > -int i915_gem_request_add_to_client(struct drm_i915_gem_request *req, > - struct drm_file *file) > +void i915_gem_request_add_to_client(struct drm_i915_gem_request *req, > + struct drm_file *file) > { > - struct drm_i915_private *dev_private; > struct drm_i915_file_private *file_priv; > > - WARN_ON(!req || !file || req->file_priv); > + GEM_BUG_ON(!req || !file || req->file_priv); > I might be inclined to drop this completely, we're going to OOPS anwyway if one of those is null. Anyway; Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx