Re: [PATCH] drm/i915: Cleanup i915_gem_request_add_to_client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 27/09/2016 13:19, Chris Wilson wrote:
On Tue, Sep 27, 2016 at 01:07:13PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Several things we can clean up in this function:

  * Request and file passed in cannot be NULL. There is
    a single caller which makes it impossible so change
    that condition to a GEM_BUG_ON instead of a WARN
    with a return code.
And move it next to the single caller since this is a specialised
function that is tied to userspace batches.

I thought about it, so OK, will do that.

And the spinlock here is superfluous.

Hm why? There are places which iterate the list.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux