On ti, 2016-09-20 at 09:30 +0100, Chris Wilson wrote:
> +__maybe_unused static bool is_kernel_context(struct drm_i915_private *dev_priv)
__maybe_unused definitely most definitely does not belong here. Need
solve the GEM_BUG_ON otherwise. Also, "is_in_kernel_context" as you
have "switch_to_kernel_context" as counterpart.
> @@ -929,21 +929,30 @@ int i915_switch_context(struct drm_i915_gem_request *req)
> int i915_gem_switch_to_kernel_context(struct drm_i915_private *dev_priv)
> {
> struct intel_engine_cs *engine;
> + struct i915_gem_timeline *timeline;
>
Lockdep here? While we're around and add more code.
With the __maybe_unused removed;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
