I started to review Libin's series at [1], but decided that intel_audio.c is badly in need of some cleanup before moving forward with the patches. I think the prep work makes Libin's patches cleaner too. I ended up rebasing the patches myself, but it was a rather quick job, with no testing, so please do double check. BR, Jani. [1] https://patchwork.freedesktop.org/series/11252/ Jani Nikula (6): drm/i915/audio: abstract audio config update drm/i915/audio: port is going to be just fine, simplify checks drm/i915/audio: use the same code for updating audio config drm/i915/audio: split dp and hdmi audio config update drm/i915/audio: add register macros for audio config N value drm/i915/audio: rename N value getter to emphasize it's for hdmi Libin Yang (3): drm/i915/audio: set proper N/MCTS on more platforms drm/i915/audio: HDMI audio gets the TMDS clock by crtc_clock drm/i915: set proper N/M in modeset drivers/gpu/drm/i915/i915_reg.h | 11 ++ drivers/gpu/drm/i915/intel_audio.c | 260 ++++++++++++++++++++++++------------- 2 files changed, 179 insertions(+), 92 deletions(-) -- 2.1.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx