On Mon, Sep 12, 2016 at 04:48:51PM +0100, Tvrtko Ursulin wrote: > > * able to defer doing this until we know the object would be > > * swapped, but there is no way to do that yet. > > */ > >- i915_vma_move_to_active(from->engine[RCS].state, req, 0); > >+ i915_vma_move_to_active(from_vma, req, 0); > >+ i915_gem_object_set_dirty(from_vma->obj); > > Commit message should mention this. No. This should not be here as we removed it because we always mark the object as dirty when active on the GPU. I don't see any improvement in this patch over mine, so what's the reason for it? Certainly the lack of debug checks is odd. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
