On Fri, Sep 09, 2016 at 06:21:26PM +0530, Sagar Arun Kamble wrote: > @@ -6720,31 +6743,38 @@ void intel_enable_gt_powersave(struct drm_i915_private *dev_priv) > + if (intel_slpc_enabled()) { > + } else { > > - WARN_ON(dev_priv->rps.max_freq < dev_priv->rps.min_freq); > - WARN_ON(dev_priv->rps.idle_freq > dev_priv->rps.max_freq); > + WARN_ON(dev_priv->rps.max_freq < dev_priv->rps.min_freq); > + WARN_ON(dev_priv->rps.idle_freq > dev_priv->rps.max_freq); > > - WARN_ON(dev_priv->rps.efficient_freq < dev_priv->rps.min_freq); > - WARN_ON(dev_priv->rps.efficient_freq > dev_priv->rps.max_freq); > + WARN_ON(dev_priv->rps.efficient_freq < dev_priv->rps.min_freq); > + WARN_ON(dev_priv->rps.efficient_freq > dev_priv->rps.max_freq); You seem to be chickening out of some sanity checks on values we present to the user. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx