On ti, 2016-08-30 at 11:00 +0100, Chris Wilson wrote:
> +static void store_dword(int fd, unsigned ring,
> + uint32_t target, uint32_t offset, uint32_t value)
> +{
I'd prefer a library function (as you obviously copied this from
gem_exec_store.c), as we have more similar functions (with more or less
features) in other tests. Some of them are not even using hardcoded
magic numbers.
Adding as TODO for future.
Other than that,
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
This not need be a "basic" test?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
