On 19/08/16 15:30, Chris Wilson wrote:
On Fri, Aug 19, 2016 at 03:23:42PM +0100, Dave Gordon wrote:
In the recent patch
bc3d674 drm/i915: Allow userspace to request no-error-capture upon ...
the final version moved the flags and the associated #defines around
so they were adjacent; unfortunately, they ended up between a comment
and the thing (hw_id) to which the comment applies :(
So this patch reshuffles the comment and subject back together.
Also, as we're touching 'hw_id', let's change it from just 'unsigned'
to a fully-specified 'unsigned int', because some code checking tools
(including checkpatch) object to plain 'unsigned'.
Fixes: bc3d674462e5df5f2b33adbfcaad9edff8b827f4
You mention checkpatch and then use a commit sha that will annoy it ;)
-Chris
Strangely, it didn't object at all, even in strict mode.
$ scripts/checkpatch.pl --strict
0001-drm-i915-Reattach-comment-complete-type-specificatio.patch
total: 0 errors, 0 warnings, 0 checks, 14 lines checked
0001-drm-i915-Reattach-comment-complete-type-specificatio.patch has no
obvious style problems and is ready for submission.
Hmm ...
actually, it seems impossible to satisfy checkpatch's requirements for
references to commits. For example, with the line
commit bc3d674462e5 ("Allow userspace to request no-error-capture")
it will object to the description not matching the original commit
(because it's abbreviated), whereas if we write
commit bc3d674462e5 ("drm/i915: Allow userspace to request
no-error-capture upon GPU hangs")
as it suggests, it complains about the resulting line length:
* Possible unwrapped commit description (prefer a maximum 75 chars per line)
However wrapping the commit description as suggested leads to complaints
about the description mismatch again (as that part of the check doesn't
consider that strings inside ("") might span line breaks).
So on the whole I'm quite happy with my original commit message :)
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
