On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> @@ -771,6 +771,13 @@ static int do_rcs_switch(struct drm_i915_gem_request *req)
> if (skip_rcs_switch(ppgtt, engine, to))
> return 0;
>
> + if (!(to->engine[RCS].state->flags & I915_VMA_GLOBAL_BIND)) {
> + ret = i915_gem_object_set_to_gtt_domain(to->engine[RCS].state->obj,
> + false);
> + if (ret)
> + return ret;
> + }
> +
> /* Trying to pin first makes error handling easier. */
> ret = i915_vma_pin(to->engine[RCS].state,
> 0, to->ggtt_alignment,
This could be lifted inside the if?
> @@ -790,11 +797,6 @@ static int do_rcs_switch(struct drm_i915_gem_request *req)
> /*
> * Clear this page out of any CPU caches for coherent swap-in/out.
> */
Move/update the comment too?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
