On Thu, Dec 22, 2011 at 09:54:27AM -0800, Keith Packard wrote: > On Thu, 22 Dec 2011 01:28:36 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > Half of the users actually don't want just no tracing, but need to > > avoid the forcewake dance for correctness. So add new variants > > __I915_READ and __I915_WRITE for that. > > I'd sure like something more descriptive than '__' here. Perhaps > I915_READ_NOWAKE? Or even I915_READ_NO_FORCEWAKE? It's actually I915_READ_NO_FORCEWAKE_NOTRACE. Which is ugly, so Chris suggested the often-used (in the linux kernel) __ prefix for "raw interface, you better know what you're doing". I admit that I like that one quite a bit. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
