Re: [PATCH 07/23] drm/i915: Move HAS_GUC_UCODE definition to platform definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/07/16 18:10, Dave Gordon wrote:
On 21/07/16 11:38, Tvrtko Ursulin wrote:

On 20/07/16 22:07, Rodrigo Vivi wrote:
please kill this _ucode variation that is just a alias to guc
instead....

Not sure, it was added with a particular goal. Cc Dave in case he wants
to comment.

Regards,
Tvrtko

The comment is already in the source code, just above the lines that
this patch changes.

.Dave.

Which is to say that,
+   having a GuC that can be used for command submission
+   having a GuC that requires firmware before use
are logically distinct properties, and are both subsets of
* having GuC hardware.

We can *imagine* products that might:

(1) have a GuC that requires firmware before use ...
(2) have a GuC with predefined but reloadable firmware ...
(3) have a GuC that contains a permanent firmware image ...
 x
(a) ... which supports command submission but not SLPC
(b) ... which supports both command submission and SLPC
(c) ... which supports SLPC but not command submission

where all combinations are logically plausible, even though we only have (1a) in today's devices. So we might as well make future development easier rather than more difficult; it is always easier to make different things equivalent than to separate identical things into different cases.

.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux