This patch has nothing to do with HuC. It is changing the GuC code to allow for generic usage. But, I will change the "GuC" in the messages for "uC". I'll let you add the patch yourself as you seem to have other renames/refactors on the mailing list. Peter. -----Original Message----- From: Gordon, David S Sent: Friday, July 29, 2016 12:19 PM To: Antoine, Peter <peter.antoine@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx Subject: Re: [PATCH v3 1/6] drm/i915/guc: Make the GuC fw loading helper functions general On 06/07/16 15:24, Peter Antoine wrote: > Rename some of the GuC fw loading code to make them more general. We > will utilise them for HuC loading as well. > s/intel_guc_fw/intel_uc_fw/g > s/GUC_FIRMWARE/UC_FIRMWARE/g > > Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members, > such as 'guc' or 'guc_fw' either is renamed to 'uc' or removed for > same purpose. > > v2: rebased on top of nightly. > reapplied the search/replace as upstream code as changed. > v3: rebased again on drm-nightly. > > Signed-off-by: Alex Dai <yu.dai@xxxxxxxxx> > Signed-off-by: Peter Antoine <peter.antoine@xxxxxxxxx> > Reviewed-by: Dave Gordon <david.s.gordon@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 12 +-- > drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- > drivers/gpu/drm/i915/intel_guc.h | 39 ++++---- > drivers/gpu/drm/i915/intel_guc_loader.c | 146 ++++++++++++++--------------- > 4 files changed, 101 insertions(+), 100 deletions(-) As of yesterday, the odd-numbered patches 1 & 3 no longer apply cleanly and will need rebasing (again). Also (as of last week's Tech Forum) any series containing more than a single patch should preferably have a cover letter that at least gives a summary of the patchset as a whole. However the main problem with this patch it not what it changes, as what it fails to change. As I previously suggested (and provided code for) you need to change all the messages so they don't say "GuC" when we're actually dealing with the HuC. Updated fixup-patch attached ... .Dave. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
