On Mon, Aug 01, 2016 at 06:38:54PM +0300, David Weinehall wrote: > Use consistent naming for drm_minor, and always use kdev_to_drm_minor() > to convert kdev to drm_minor. > > Signed-off-by: David Weinehall <david.weinehall@xxxxxxxxxxxxxxx> I would have gone with struct drm_minor *minor, since there is no confusion here (and dminor is a note ;) Had you made kdev_to_drm_minor() typesafe (inline function) then I would have classed it as an overall improvement and just grumbled about the choice of name. As it stands, it doesn't make me feel the code is substantially improved. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
