On Mon, Aug 01, 2016 at 06:38:53PM +0300, David Weinehall wrote: > We currently have a mix of struct device *device, struct device *kdev, > and struct device *dev (the latter forcing us to refer to > struct drm_device as something else than the normal dev). > > To simplify things, always use kdev when referring to struct device. > > Signed-off-by: David Weinehall <david.weinehall@xxxxxxxxxxxxxxx> kdev may be confused with kdev_t, but seems reasonable due to kobj. This patch is an improvement, so Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> but I was wondering if struct device *dev; struct drm_device *drm; struct i915_device *i915; (struct i915_device is move apt now than drm_i915_private due to the subclassing) made more sense as a longterm goal? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
