On Thu, Jul 28, 2016 at 12:02:01PM +0200, Daniel Vetter wrote: > On Wed, Jul 27, 2016 at 12:14:54PM +0100, Chris Wilson wrote: > > We only need a very lightweight mechanism here as the locking is only > > used for co-ordinating a bitfield. > > > > v2: Move the cheap unlikely tests into the caller > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > I think the code shuffling in here badly breaks the kerneldoc. Best fix > would be to extract a small header for frontbuffer tracking and pull that > into the kernel doc. Much less preferred is to explicitly pull in the > kerneldoc function-by-function (but that tends to be rather fragile when > someone adds something new). You mean /** * DOC: Frontbuffer tracking overview * * ... */ in i915_drv.h before the functions? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx