On ke, 2016-07-27 at 13:30 +0100, Chris Wilson wrote: > On Wed, Jul 27, 2016 at 12:53:25PM +0100, Dave Gordon wrote: > > > > On 25/07/16 08:44, Chris Wilson wrote: > > > > > > +static void i9xx_submit_request(struct drm_i915_gem_request *request) > > > +{ > > > + struct drm_i915_private *dev_priv = request->i915; > > > + > > > + I915_WRITE_TAIL(request->engine, > > > + request->tail % (request->ring->size - 1)); > > > +} > > Another "modulo ringsize-1" here too. > Because the original code included that safe guard against known GPU > hangs. I think a comment would be justified. Regards, Joonas > -Chris > -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx