On Wed, Jul 13, 2016 at 02:40:49PM +0200, Daniel Vetter wrote: > On Wed, Jun 29, 2016 at 12:38:51PM +0100, Chris Wilson wrote: > > Several years ago we made the plan of only having one canonical source > > for i915_pciids.h, the kernel and everyone importing their definitions > > from that. For consistency, we style the intel_device_info after the > > kernel, most notably using a generation mask and a per-codename bitfield. > > > > This first step converts looking up the generation for a devid tree from > > a massive if(devid)-chain to a (cached) table lookup. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Should we extract the kernels list of chipset into intel_chipset.c too, to > make them 1:1 copies like with i915_pciids.h? With that this (entire > series) here has my ack. Without I'm not sold that much on the churn > really. Hmm, next up would be libdrm which is almost a duplication of igt (and can be massaged to be so). The next step would be feeding back the commonality into the kernel, so that we really do have a single location where we need to add new defines that can just percolate through. So I think you mean to have the device-info stanzas shared... -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
