> Ellie, can you please fix the listen statement to accept correctly
> bracketed ipv6 and backport to at least 2.5 and 2.4, shouldn't be many
> changes in that code.
I don't think there's anything to fix here. The code looks fine as is,
just docs missing. Unless we want to explicitly *not* accepted
un-bracketed "ip6-address ':' port"? But forbidding that seems silly,
considering it requires adding code to remove functionality.
This code hasn't changed since 2012, when it was refactored by 306099b.
It's in the same state (modulo tabs/spaces change) on 2.5 and master
branches. The 2.4 version is significantly different, as it didn't get
the refactor (but that doesn't appear to be a problem here).
I'm scouring the thread trying to figure out if there's even a problem
being reported (other than lack of docs) and I can't see it. It seems
to have gone like:
Sebastian: How do I do this?
Various: It's not in docs, but try this...
Sebastian: I tried this and it worked
Sebastian, is there anything you tried that *didn't* work, and if so,
what happened?
Cheers,
ellie
On Mon, Mar 28, 2016, at 04:24 PM, Bron Gondwana wrote:
> Ellie, can you please fix the listen statement to accept correctly
> bracketed ipv6 and backport to at least 2.5 and 2.4, shouldn't be many
> changes in that code.
>
> Nicola, can you check that we document how it's working now, and of
> course the fixed version :)
>
> Bron (on phone in bush somewhere)
>
> On Thu, Mar 24, 2016, at 05:10, Hajimu UMEMOTO via Info-cyrus wrote:
> > Hi,
> >
> > >>>>> On Wed, 23 Mar 2016 17:43:30 +0100
> > >>>>> Sebastian Hagedorn <Hagedorn@xxxxxxxxxxxx> said:
> >
> > > * Parse the "listen" parameter as one of the forms:
> > > *
> > > * hostname
> > > * hostname ':' port
> > > * ipv4-address
> > > * ipv4-address ':' port
> > > * '[' ipv4-address ']'
> > > * '[' ipv4-address ']' ':' port
> > > * '[' ipv6-address ']'
> > > * '[' ipv6-address ']' ':' port
> >
> > The `ipv6-address ':' port' notation is also accepted. However, it is
> > not mentioned even in the comment.
> >
> > Hagedorn> Thank you! Perhaps that should go into the manpage of cyrus.conf?
> >
> > I'm not sure but I think the bracket notation is recommended.
> >
> > Sincerely,
> >
> > --
> > Hajimu UMEMOTO
> > ume@xxxxxxxxxxxx ume@xxxxxxxxxxx
> > http://www.mahoroba.org/~ume/
> > ----
> > Cyrus Home Page: http://www.cyrusimap.org/
> > List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
> > To Unsubscribe:
> > https://lists.andrew.cmu.edu/mailman/listinfo/info-cyrus
>
>
> --
> Bron Gondwana
> brong@xxxxxxxxxxx
----
Cyrus Home Page: http://www.cyrusimap.org/
List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
To Unsubscribe:
https://lists.andrew.cmu.edu/mailman/listinfo/info-cyrus
