Reviewer: Linda Dunbar Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-teas-yang-te-types-?? Reviewer: Linda Dunbar Review Date: 2019-05-14 IETF LC End Date: 2019-05-16 IESG Telechat date: Not scheduled for a telechat Summary: This document defines all the "Identity" (or types) for TE data types. Therefore, it is hard to tell if all the types are completely specified without cross reference to the TE specification drafts. For example, I tried to cross reference to RFC3209 on "identity local-protection-desired", the words are not completely matched in RFC3209. (e.g. identity local-protection-desired { base session-attributes-flags; description "Fastreroute local protection is desired."; reference "RFC3209"; } It would make it much easier to validate the YANG model if the page number of the referenced RFC is listed in the Reference, or the actual TLV being referenced are described. Major issues: Minor issues: Nits/editorial comments: Add the page number of the referenced RFC to make it easier to validate the correctness of the "types", or describe the actual TLV being referenced .
