Hi Russ, Thank you for the review. Please see inline. Cheers, Med > -----Message d'origine----- > De : Russ Housley via Datatracker <noreply@xxxxxxxx> > Envoyé : jeudi 16 janvier 2025 21:27 > À : gen-art@xxxxxxxx > Cc : draft-ietf-netmod-acl-extensions.all@xxxxxxxx; last- > call@xxxxxxxx; netmod@xxxxxxxx > Objet : Genart last call review of draft-ietf-netmod-acl- > extensions-13 > > > Reviewer: Russ Housley > Review result: Almost Ready > > I am the assigned Gen-ART reviewer for this draft. The General > Area Review Team (Gen-ART) reviews all IETF documents being > processed by the IESG for the IETF Chair. Please treat these > comments just like any other last call comments. > > For more information, please see the FAQ at > <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F% > 2Fwiki.ietf.org%2Fen%2Fgroup%2Fgen%2FGenArtFAQ&data=05%7C02%7Cmoh > amed.boucadair%40orange.com%7C91dce1230bfe4bad9a8808dd366c357d%7C > 90c7a20af34b40bfbc48b9253b6f5d20%7C0%7C0%7C638726560566279411%7CU > nknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIs > IlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sda > ta=ayNSTqOWqbvndOtnIpT5ilr2gULS5fb2bUPlPNu%2B0XM%3D&reserved=0>. > > Document: draft-ietf-netmod-acl-extensions-13 > Reviewer: Russ Housley > Review Date: 2025-01-16 > IETF LC End Date: 2025-01-27 > IESG Telechat date: Unknown > > > Summary: Almost Ready > > > Major Concerns: None > > > Minor Concerns: > > Appendix D.2 talks about defined sets, and it offers four > categories (prefix sets, protocol sets, port number sets, and > ICMP sets). Then, Appendix D.2 talks about aliases, and it > offers examples of five categories (prefix, protocol, port > number, FQDN,and VLAN IDs). I was expecting some discussion > about when to use a defined set and when to use an alias. Maybe > someone more familiar with YANG would find this discussion > sufficient, but I felt that a bit more discussion would be > helpful to me. > [Med] In addition to the definition entries in 3.2., we do have the following: Aliases may also be considered to manage resources that are identified by a combination of various parameters (e.g., prefix, protocol, port number, FQDN, or VLAN IDs). Note that some aliases can be provided by decomposing them into separate sets. Added the following to Section 3.2 to further insist on the intended usage: NEW: When only sets of one specific parameter (e.g., protocol) are handled, then the relevant parameter sets should be used (e.g., protocol set) rather than an alias. Note that we don't need to use the normative language here as this is more a deployment choice than an interop concern. > > Nits: > > IDnits points out that some lines are too long: > > ** There are 2 instances of too long lines in the document, the > longest one being 2 characters in excess of 72. > [Med] Fixed. Thanks. > IDnits points out some outdated references: > > == Outdated reference: A later version (-22) exists of > draft-ietf-netmod-rfc8407bis-21 > [Med] ACK. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
