Hi Dhruv,
On Jan 6, 2025, at 01:28, Dhruv Dhody <dd@xxxxxxxxxxxxxx> wrote:
Hi Acee,
Thanks for incorporating my comments. Just a few more thoughts...
>
> - Figure 1, I dont understand the reason for labeling the servers as
> A,O,B,O,Z,O,O,O? Further, it might also be worth to explain the topology in
> words clearly marking which nodes belong to which tier as the figure could be
> confusing (for example, is Node 3 Tier-1 or 3 could be unclear from just the
> figure).
I’ve improved the figure and believe I’ve made the tiers evident.
Dhruv: I am a little unsure about the change. When I saw figures 3 and 4 in RFC 7938 (which I assume is the inspiration for this figure),
Yes. I considered NODE 3,7,10,12 to be part of Tier 1.
Right - you can tell this wasn’t my original figure. I’ve fixed.
Also why the labels of the server now A,B,B,A and X,Z,Z,X - perhaps that can be explained in words - because it is not obvious to me.
This was meant to show redundant server connections. However, this is ancillary to BGP SPF deployment and I changed it to match RFC 7938.
>
> - Various instances of articles (a, an, the) missing.
I didn’t see any of these offhand. Note that “policy” in this context can be considered plural.
Dhruv: We could leave those for the professionals in RPC but since you asked - s/improve convergence/improve the convergence/
I think it reads fine without the article. I’ll leave to the RFC Editor.
s/BGP sessions in hop-by-hop peering/BGP sessions in the hop-by-hop peering/
Accepted. s/serialized by BGP best-path algorithm/serialized by the BGP best-path algorithm/
Accepted. s/announcement of BGP-SPF link-state/announcement of the BGP-SPF link-state/
Accepted. s/With this heuristic, discovery of BGP SPF/With this heuristic, the discovery of BGP SPF/
I think it reads fine without the article. I’ll leave to the RFC Editor.
s/In the context of a data center fabric, direction is either/In the context of a data center fabric, the direction is either/
Accepted. s/(same level in hierarchy)/(same level in the hierarchy)/
Accepted. s/However, BGP speaker/However, a BGP speaker/
Accepted. s/then configuration of IPv6 global addresses/then the configuration of IPv6 global addresses/
I think it reads fine without the article. I’ll leave to the RFC Editor.
Thanks, Acee
--
and found new spelling mistakes - s/an adverised link/an advertised link/ s/BGP SPF route calcuation/BGP SPF route calculation/
Thanks! Dhruv
|