Dear all, I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments. The summary of the review is Not Ready. The draft does a good job of describing the FNV-1a hash function. However, it falls short on recommending when it should be used and when it should not be. Python had to change away from FNV-1a due to collision attacks leading to DoS (https://peps.python.org/pep-0456/, https://www.youtube.com/watch?v=Vdrab3sB7MU). The offset is insufficient to solve this problem. FNV-1a is slower than other hash functions with better guarantees of equidistribution, taking one multiply per byte and is hard to parallelize. I think this draft needs to say these things, and advise against usage in new applications and protocols. Sincerely, Watson Ladd -- Astra mortemque praestare gradatim -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
