[Last-Call] Re: [OPS-DIR]Re: Opsdir last call review of draft-ietf-teas-actn-vn-yang-26

"Wubo \(lana\)" <lana.wubo=40huawei.com@xxxxxxxxxxxxxx> · Tue, 25 Jun 2024 07:55:39 +0000

Hi Mahesh, Dhruv,

Sorry I missed the email. I agree with the update. Thank you both for the good discussion and addressing my comments.

Regards,
Bo

From: Mahesh
 Jethanandani <mjethanandani@xxxxxxxxx> 

Sent: Saturday, June 22, 2024 8:51 PM

To: Dhruv Dhody <dhruv.ietf@xxxxxxxxx>

Cc: Wubo (lana) <lana.wubo@xxxxxxxxxx>; ops-dir@xxxxxxxx; draft-ietf-teas-actn-vn-yang.all@xxxxxxxx; Last Call <last-call@xxxxxxxx>; teas@xxxxxxxx

Subject: Re: [OPS-DIR]Re: Opsdir last call review of draft-ietf-teas-actn-vn-yang-26

Hi Dhruv,

Looks good to me. Thanks for addressing my comments. Wubo, would you agree?

On Jun 22, 2024, at 6:34 AM, Dhruv Dhody <dhruv.ietf@xxxxxxxxx> wrote:

Hi Mahesh, 

On Tue, Jun 11, 2024 at 12:41 AM Mahesh Jethanandani <mjethanandani@xxxxxxxxx>
 wrote:

Hi Dhruv,

On Jun 10, 2024, at 12:58 PM, Dhruv Dhody <dhruv.ietf@xxxxxxxxx>
 wrote:

Hi Mahesh,

On Sat, Jun 8, 2024 at 9:47 PM Mahesh Jethanandani <mjethanandani@xxxxxxxxx>
 wrote:

Hi Dhruv,

On Jun 7, 2024, at 2:57 AM, Dhruv Dhody <dhruv.ietf@xxxxxxxxx>
 wrote:

>From this sentence, it seems that LTP refers to the LTP in the native TE

topology, because in YANG, PE is defined as the PE node in the native TE

Topology. While in the YANG model and the Examples in B.1. VN JSON, it looks

like "ltp" is the LTP within the abstract node, correct? If so, could the YANG

path be modified to a relative path of the abstract node?

Dhruv: Since the 'te-node-id' is not a key, it is not possible to change to relative path like "path
 "/nw:networks/nw:network/nw:node[tet:te-node-id=current()/../abstract-node]/nt:termination-point/tet:te-tp-id";"

Instead I will update the description. 

I am not able to understand this comment. I understand that you cannot provide a path like you mention
 above, but at the same time, Wubo does make a good point. Which LTP is being referred to? The one in the underlying layer or in the abstract layer?

Dhruv: To handle this comment from Bo, I updated the description of this leaf to explicitly
 say abstract-node. 

           leaf ltp {

             type leafref {

               path "/nw:networks/nw:network/nw:node/"

                  + "nt:termination-point/tet:te-tp-id";

             }

             description

               "A reference to Link Termination Point (LTP) in the

                abstract-node.";

             reference

               "RFC 8795: YANG Data Model for Traffic Engineering (TE)

                Topologies";

           }

Is there anything else that I should be doing? 

It is entirely possible that I have not understood the model, so do educate me if necessary.

By providing an absolute reference, and using the XPath that you have, I get this to be a reference to
 the underlying layer, not the abstract layer. But maybe the XPaths in the underlying layer are the same as in the abstract layer, in which case I am wrong. Regardless, by using a relative XPath, you will stay in the layer that you are currently in without
 any confusion. Won’t you?

Dhruv: To handle your comments, I have made this change in the newly uploaded -29 version - 

           leaf abstract-node {
             type leafref {
               path "/nw:networks/nw:network/nw:node/nw:node-id";
             }
             must '/nw:networks/nw:network/nw:node[nw:node-id='
                + 'current()/../abstract-node]/tet:te-node-id' {
               description
                 "The associated network for the abstract-node
                  must be TE enabled.";
             }
             description
               "A reference to the abstract node that represent
                the VN.";
           }
           leaf ltp {
             type leafref {
               path "/nw:networks/nw:network/nw:node[nw:node-id="
                  + "current()/../abstract-node]/nt:termination-point/"
                  + "tet:te-tp-id";
             }
             description
               "A reference to Link Termination Point (LTP) in the
                abstract-node i.e. the LTP should be in the abstract
                layer, and not the underlying layer.";
             reference
               "RFC 8795: YANG Data Model for Traffic Engineering (TE)
                Topologies";
           }

Diff: https://author-tools.ietf.org/iddiff?url2=draft-ietf-teas-actn-vn-yang-29

1) Change abstract-node to point to the key node-id

2) Add a must statement to make sure the network is TE enabled

3) ltp leafref points to tp-id in the abstract-node

Thanks! 

Dhruv

Thanks! 

Dhruv

Mahesh Jethanandani

mjethanandani@xxxxxxxxx

Mahesh Jethanandani

mjethanandani@xxxxxxxxx

Mahesh Jethanandani

mjethanandani@xxxxxxxxx

-- 
last-call mailing list -- last-call@xxxxxxxx
To unsubscribe send an email to last-call-leave@xxxxxxxx