Hi Tim, Thank you for the review. The changes made to take into account this review can be seen at: https://github.com/boucadair/-ipfix-rfc7125-update/pull/5/files. Please see inline for more context. Cheers, Med > -----Message d'origine----- > De : Tim Bray via Datatracker <noreply@xxxxxxxx> > Envoyé : lundi 16 octobre 2023 18:33 > À : art@xxxxxxxx > Cc : draft-ietf-opsawg-rfc7125-update.all@xxxxxxxx; last- > call@xxxxxxxx; opsawg@xxxxxxxx > Objet : Artart last call review of draft-ietf-opsawg-rfc7125-update-05 > > Reviewer: Tim Bray > Review result: Ready with Nits > > The last time I thought about TCP header bits was in 1998, so all the > revision history and technical content is opaque to me. I have a few > nits on formatting and language, which may be entirely off-base > because of my lack of context. > > Nits: > > 1. Introduction - why is the single sentence beginning "The bits in > offsets 0 through 3" indented that way? Should it have "Note:" or > something in front? Is the middle of the section the right place for > it? [Med] That is a note to recall that these bits aren’t flag bits. Added "Note:". > > 2. Section 3 - "for each TCP control bit, there is a bit in this set" > - took me a bit of mental work to parse. Upon re-reading, I think you > could maybe just lose this: "This information is encoded as a bit > field; the bit is set to 1 if any observed packet of this Flow has the > corresponding TCP control bit set to 1." [Med] That part of the text was inherited from RFC7125. Updated slightly the text for better clarity. > > 3. Section 3 - This section makes regular use of the verb "export", > does this in effect mean "set"? Should that be made explicit? [Med] The use of export here is consistent with the usage in IPFIX context/specs. No change is made here. > > 4. Section 5 - " an exporter has to report " - should "has to" be > "MUST"? > [Med] No normative language is used here because otherwise this will be redundant with other part of the text: All TCP control bits (including those unassigned) MUST be exported as observed in the TCP headers of the packets of this Flow. ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you. -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
