Hi Dhruv, Indeed in 8060 the length unit is one single byte, hence there is no need of padding. Thanks for your review. Ciao L. > On 27 Apr 2022, at 05:48, Dhruv Dhody <dd@xxxxxxxxxxxxxx> wrote: > > Hi Dino, > > In some protocols that I am aware of, it is usual to state that the > variable-length portion in the TLVs/objects is 4-byte aligned. But looking > at RFC 8060, I see that LISP does not follow this approach for any of the > LCAF and it works just fine without it. I agree with you that no change is > required then. Thanks for taking my comment into consideration. > > Thanks! > Dhruv > > On Wed, Apr 27, 2022 at 3:19 AM Dino Farinacci <farinacci@xxxxxxxxx> wrote: > >> Dhruv, can you explain more specifically what you mean by padding? Since >> any LCAF encoding (even a vendor LCAF) has a length field, the encoding can >> be the exact number of bytes described by the length. So no padding is >> required. >> >> Or did you mean something else? >> >> Dino >> >>> On Apr 26, 2022, at 7:49 AM, Alberto Rodriguez-Natal (natal) < >> natal@xxxxxxxxx> wrote: >>> >>> Hi Dhruv, >>> >>> Thanks for your review! You’re bringing good points. >>> >>> As per your comment on padding, it’s a good question but I cannot recall >> right now any padding requirement in other LISP docs. A a quick search for >> ‘padding' in rfc6833bis and RFC8060 shows not results. Maybe someone else >> on the list can comment on padding requirements in LISP (if any)? >>> >>> Also, good point on expanding LISP on first use, we’ll make sure to do >> so in the revised draft. >>> >>> Thanks! >>> Alberto >>> >>> From: Dhruv Dhody via Datatracker <noreply@xxxxxxxx> >>> Date: Tuesday, April 26, 2022 at 4:03 PM >>> To: rtg-dir@xxxxxxxx <rtg-dir@xxxxxxxx> >>> Cc: draft-ietf-lisp-vendor-lcaf.all@xxxxxxxx < >> draft-ietf-lisp-vendor-lcaf.all@xxxxxxxx>, last-call@xxxxxxxx < >> last-call@xxxxxxxx>, lisp@xxxxxxxx<lisp@xxxxxxxx> >>> Subject: Rtgdir last call review of draft-ietf-lisp-vendor-lcaf-10 >>> >>> Reviewer: Dhruv Dhody >>> Review result: Has Issues >>> >>> I was assigned the reviewer today. I noticed that the IESG ballot is >> done and >>> the document is approved, I am not sure how valuable this review would >> be but >>> anyways... >>> >>> Hello, >>> >>> I have been selected as the Routing Directorate reviewer for this draft -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
