Hi Christer, Thanks for your review. > On Apr 15, 2021, at 3:34 PM, Christer Holmberg via Datatracker <noreply@xxxxxxxx> wrote: > > [External Email. Be cautious of content] > > > Reviewer: Christer Holmberg > Review result: Almost Ready > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://urldefense.com/v3/__https://trac.ietf.org/trac/gen/wiki/GenArtfaq__;!!NEt6yMaO-gk!SpXM0yYhkqFsTZDByFUPco5EutovKUYeL5VoR2Wb7DUHLrZxG7pdNLoL2KrhyA$ >. > > Document: draft-ietf-idr-ext-opt-param-11 > Reviewer: Christer Holmberg > Review Date: 2021-04-15 > IETF LC End Date: 2021-04-09 > IESG Telechat date: 2021-04-22 > > Summary: The document is easy to read, and I have no technical issues. However, > I do have a minor question, and a couple of editorial suggestions, that I'd > like the authors to address. > > Major issues: N/A > > Minor issues: > > Q1: As far as I understand, the document only defines a new BGP OPEN Optional > Parameter Type, but does not modify/add procedures in RFC 4271. So, is the > document really an update to RFC 4271? And, when reading RFC 5429, I cannot > find any text saying that new parameter types would require an update to RFC > 4271. I also looked at a few other RFCs that add new values to the BGP IANA > registry, and they were not updating any RFC. The document modifies the way a router parses the OPEN. It doesn’t just add a new type, indeed the new type is only added as a special token to tell the router to use the new procedures. > Nits/editorial comments: > > Q2: I suggest that Section 2 is renamed to "New Optional Parameter Type code", > or something like that. OR, if the document really is updating RFC 4271, > perhaps "Update to RFC 4271". I’ve adopted your second suggestion. > Q3: I suggest that Section 3 is renamed to "Backward Compatibility", or > something like that. Done. —John -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
