On 7/10/2020 8:20 AM, Andy Shevchenko wrote:
On Fri, Jul 10, 2020 at 11:00 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Hi,
On 7/9/20 8:02 PM, Andy Shevchenko wrote:
On Fri, Jul 3, 2020 at 4:24 AM Mark Pearson <markpearson@xxxxxxxxxx> wrote:
Newer Lenovo Thinkpad platforms have support to identify whether the
system is on-lap or not using an ACPI DYTC event from the firmware.
This patch provides the ability to retrieve the current mode via sysfs
entrypoints and will be used by userspace for thermal mode and WWAN
functionality
Hans, do you think it's good to have custom ABI for this? I think you
may be know better what types of ABI we already have for such thing.
Actually, Mark asked me the same question before submitting his
patch upstream. I'm never a fan of custom ABI for this. But for now
the solution Lenovo has chosen to deal with thermal management
issues on modern hw is unique to Lenovo and we do not have anything
like this anywhere else.
So for now I believe that a custom ABI is best.
If we see this becoming a common feature on more platforms then we can
design a generic API for it once we have a better idea how this would
look like when implemented by others and then thinkpad_acpi can easily
add support for the new generic interface, while keeping its own
custom interface for backward compatibility.
Thank you very much for the elaborative comment, appreciated!
Yes, thanks Hans from me too.
Just to note, I'm very happy to work on or contribute to a generic
framework if that makes sense in the future. I'd likely need some help &
guidance on the best way to do it but if you see a need let me know.
Andy - let me know if you need anything else for this patch. I have a
follow on patch for a similar sensor that I'll send up once this one is
approved - I figured we should learn from our mistakes on this one
before duplicating the errors.
Thanks all for the support, reviews and guidance
Mark
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
