On 18-01-03 08:37:49, Henrique de Moraes Holschuh wrote: > On Tue, 02 Jan 2018, mthode@xxxxxxxxxx wrote: > > From: Matthew Thode <mthode@xxxxxxxxxx> > > > > Signed-off-by: Matthew Thode <mthode@xxxxxxxxxx> > > Please, could you add some far more verbose explanations to the > (currently empty) commit log? > > Such as: which thinkpad models you know to have this feature, how one is > expected to use it, in which thinkpads you tested the patch, etc... > > Also, please send me a copy of the dmidecode output and full ACPI tables > of a thinkpad that has this. Please remove any UUIDs and serial > numbers, first. > > Thanks! > > > + case TP_HKEY_EV_PALM_UNDETECT: > > + /* we do nothing here */ > > But we could, depending on the usecase for the feature? Should we? So far, via perusing bugreports for those IDs it seems like it's only on the X1 Carbon 5th gen (which I have and tested the patch on). I'm sending the files directly to you in a separate email. -- Matthew Thode
Attachment:
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
