Re: [PATCH] Add Thinkpad palm detection acpi codes to thinkpad_acpi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 02 Jan 2018, mthode@xxxxxxxxxx wrote:
> From: Matthew Thode <mthode@xxxxxxxxxx>
> 
> Signed-off-by: Matthew Thode <mthode@xxxxxxxxxx>

Please, could you add some far more verbose explanations to the
(currently empty) commit log?

Such as: which thinkpad models you know to have this feature, how one is
expected to use it, in which thinkpads you tested the patch, etc...

Also, please send me a copy of the dmidecode output and full ACPI tables
of a thinkpad that has this.  Please remove any UUIDs and serial
numbers, first.

Thanks!

> +	case TP_HKEY_EV_PALM_UNDETECT:
> +		/* we do nothing here */

But we could, depending on the usecase for the feature?  Should we?

-- 
  Henrique Holschuh

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel



[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux