On Mon, Mar 30, 2015 at 02:26:42PM +0200, Yves-Alexis Perez wrote:
> On Mon, Mar 30, 2015 at 02:12:44PM +0200, Yves-Alexis Perez wrote:
> > ThinkPad don't use an EC-based brightness interface anymore, they use
> > ACPI video interface or (since Windows 8 generation laptops) GPU
> > interface. Don't output a scary warning by default and demote it to
> > debug.
> >
> Here's a quick attempt.
> > @@ -6359,7 +6356,12 @@ static int __init brightness_init(struct ibm_init_struct *iibm)
> >
> > /* if it is unknown, we don't handle it: it wouldn't be safe */
> > if (tp_features.bright_unkfw)
> > + {
> > + dbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_BRGHT,
> > + "unsupported brightness interface, "
> > + "please use ACPI video or GPU drivers\n");
> > return 1;
> > + }
> >
> But I'm really not sure about the “please use ACPI video…” phrase. Even
> only for debugging, I'm not sure it's really helpful. If an user sees
> that phrase, I'm not sure he'll really know what to do. Any thought?
And then, later in brightness_init(), we have a call to
acpi_video_backlight_support() (which is outside of our control), and if
it returns true, then we output that log:
[16994.459693] thinkpad_acpi: This ThinkPad has standard ACPI backlight
brightness control, supported by the ACPI video driver
Maybe that call shouldn't return true for this ThinkPad (since the ACPI
video interface is actually disabled, afair), but it might be worth
handling that too, what do you think?
Regards,
--
Yves-Alexis
Attachment:
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
