ThinkPad don't use an EC-based brightness interface anymore, they use
ACPI video interface or (since Windows 8 generation laptops) GPU
interface. Don't output a scary warning by default and demote it to
debug.
Signed-off-by: Yves-Alexis Perez <corsac@xxxxxxxxxx>
---
drivers/platform/x86/thinkpad_acpi.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 3b8ceee..dcea451 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6324,19 +6324,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
* going to publish a backlight interface
*/
b = tpacpi_check_std_acpi_brightness_support();
+ pr_debug("detected a %d-level brightness capable ThinkPad\n", b);
switch (b) {
case 16:
bright_maxlvl = 15;
- pr_info("detected a 16-level brightness capable ThinkPad\n");
break;
case 8:
case 0:
bright_maxlvl = 7;
- pr_info("detected a 8-level brightness capable ThinkPad\n");
break;
default:
- pr_err("Unsupported brightness interface, "
- "please contact %s\n", TPACPI_MAIL);
tp_features.bright_unkfw = 1;
bright_maxlvl = b - 1;
}
@@ -6359,7 +6356,12 @@ static int __init brightness_init(struct ibm_init_struct *iibm)
/* if it is unknown, we don't handle it: it wouldn't be safe */
if (tp_features.bright_unkfw)
+ {
+ dbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_BRGHT,
+ "unsupported brightness interface, "
+ "please use ACPI video or GPU drivers\n");
return 1;
+ }
if (!brightness_enable) {
dbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_BRGHT,
--
2.1.4
--
Yves-Alexis
Attachment:
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
