-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Fri, Mar 27, 2015 at 08:36:51AM -0300, Henrique de Moraes Holschuh wrote: > On Fri, Mar 27, 2015, at 04:11, Yves-Alexis Perez wrote: > > On dim., 2015-03-22 at 16:12 -0300, Henrique de Moraes Holschuh wrote: > > > On Sat, Mar 7, 2015, at 17:12, Jarmila Holcova wrote: > > > > Mar 7 20:34:47 OH-ThinkPad-Edge-E440 kernel: [ 10.725697] > > > > thinkpad_acpi: Unsupported brightness interface, please contact > > > > ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx > > > > > > Thanks for the report. You can ignore this error message. > > > > Would it be worth dropping the message for those boxes? > > Yes. They are currently not really useful. > > I think it would make sense to rework > tpacpi_detect_brightness_capabilities() to just pr_debug() something > like "firmware reports %d brightness levels" after it has processed the > result of tpacpi_check_std_acpi_brightness_support(). > > We should leave any complaining about supported/unsupported to > brightness_init(), so it would make sense to add a dbg_printk to > brightness_init that reports "unsupported brightness mode, use acpi > video or gpu drivers" when tp_features.bright_unkfw is not zero. > > Care to send a patch? I'll try to. For what it's worth, tpacpi_check_std_acpi_brightness_support() returns 646 here (ThinkPad X250 20CMCTO1WW with BIOS N10ET29W (1.06). Regards, - -- Yves-Alexis -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCgAGBQJVGQ3oAAoJEG3bU/KmdcCl8kgH/3S4+nzJ3L/MTVxQ/M1Xoxy6 4MAY+J3ym3STMt+rZBqRojkCPvAjWEQZGuaZRrQeHyrwi3Ff01y0IzvInrzaHOBU qSULSZqE8jY7crXx8/rFB4dDjNHr1IfMxnnKladLXdYQ8o8vP+KXGEssfaNrGCi6 s7LchCNe2vxbjM30FPAKW7QzzsNbOK/hvhiuk/cZ8t8xYlzUhNeRJ9ttvstS4QuW cp6L5kuwf9VHYfNXs3dpN4eAf8jYFTod6jD6/ma0ARHxT0N1GUTbwY25rfCEYmb9 zmTwScFb4SDiVt6ki3guTUk4tCpYNA+0DK99mpAsaAKO9i6hL2b+fF15B/QaBKM= =5qfr -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
