On Fri, Mar 27, 2015, at 04:11, Yves-Alexis Perez wrote: > On dim., 2015-03-22 at 16:12 -0300, Henrique de Moraes Holschuh wrote: > > On Sat, Mar 7, 2015, at 17:12, Jarmila Holcova wrote: > > > Mar 7 20:34:47 OH-ThinkPad-Edge-E440 kernel: [ 10.725697] > > > thinkpad_acpi: Unsupported brightness interface, please contact > > > ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx > > > > Thanks for the report. You can ignore this error message. > > Would it be worth dropping the message for those boxes? Yes. They are currently not really useful. I think it would make sense to rework tpacpi_detect_brightness_capabilities() to just pr_debug() something like "firmware reports %d brightness levels" after it has processed the result of tpacpi_check_std_acpi_brightness_support(). We should leave any complaining about supported/unsupported to brightness_init(), so it would make sense to add a dbg_printk to brightness_init that reports "unsupported brightness mode, use acpi video or gpu drivers" when tp_features.bright_unkfw is not zero. Care to send a patch? -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
