On Fri, 31 Aug 2012, Andrea Oliveri wrote: > 1) Defines a new field in struct tpacpi_quirk: bios_date, an unsigned > int field that contain the bios release date of the machine in this > format MMDDYYYY (e.s 04/23/1988 -> 04231988). I introduced it because in > new bioses there isn't the EC version string (precisely this string > exists but it's not attainable from the kernel with the DMI syscall > family, no ACPI method exist in DSDT table to extract it). I set to 0 > the bios release date of other thinkpad in quirks list and i used for > the new generation machines (like T430) the quirk type TPV_QL0 It is acceptable to get the EC version directly from the EC register space, as long as you do DMI matches beforehand. That might be better than a date-based quirk list. You say the string does exist. Where is it? WMI? > 3) I change some parts of the thermal subdriver, so it's possibile for > new generation thinkpad without EC version string to export in sysfs the > temperature informations also i set the subdriver to export in sysfs > only the temperature sensors present in the machine (no an infinite list > of tempX_input with 0 value). This is an incompatible change in the userspace ABI, which is absolutely unacceptable except in the most extreme cases. It has to be fixed in some other way. How does the temperature sensors behave in the newer Lenovo ECs? > I post here the patch file http://pastebin.com/ZDxZyw1P > > I discovered some interesting facts about mute LED, GPS, _OSI string, > and accelerometer. So I continue to work to implement these features. Care to document them before you attempt to publish any code changes? Depending on how you discovered them [e.g. you decompiled or disassembled windows drivers], we will need a clean-room implementation aproach, where you document how to do it, and someone else writes the code. > Be lenient, its my first patch at kernel driver that i make =) It has some rough edges for sure. If you want to improve on that area, read Documentation/SubmittingPatches in the kernel source tree... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
