Re: thinkpad_acpi: Add support for T410s.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2010-04-20 at 23:03 +0200, Jens Taprogge wrote:
> Hello Henrique.
> 
> A new LED is integrated into the Microphone mute button.  On the other hand many
> LEDs are missing and have been masked out from useful_leds.  A new hotkey event
> triggered when pressing the Microphone Mute button.  It is reported as an ACPI
> hotkey event.
> 
> Please apply.
> 
> Signed-off-by: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> ---
>  drivers/platform/x86/thinkpad_acpi.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 63290b3..2cee76c 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -160,6 +160,7 @@ enum tpacpi_hkey_event_t {
>  	TP_HKEY_EV_VOL_UP		= 0x1015, /* Volume up or unmute */
>  	TP_HKEY_EV_VOL_DOWN		= 0x1016, /* Volume down or unmute */
>  	TP_HKEY_EV_VOL_MUTE		= 0x1017, /* Mixer output mute */
> +	TP_HKEY_EV_VOL_MUTE_MIC		= 0x101b, /* Microphone mute */

One thing I've been thinking about is getting a standard key defined for
microphone mute in linux/input.h as well.

>  
>  	/* Reasons for waking up from S3/S4 */
>  	TP_HKEY_EV_WKUP_S3_UNDOCK	= 0x2304, /* undock requested, S3 */
> @@ -5031,6 +5032,8 @@ static const char * const tpacpi_led_names[TPACPI_LED_NUMLEDS] = {
>  	"tpacpi::unknown_led2",
>  	"tpacpi::unknown_led3",
>  	"tpacpi::thinkvantage",
> +	NULL,
> +	"tpacpi::mute_mic",
>  };
>  #define TPACPI_SAFE_LEDS	0x1081U
>  
> @@ -5247,6 +5250,8 @@ static const struct tpacpi_quirk led_useful_qtable[] __initconst = {
>  	TPACPI_Q_IBM('7', '7', 0x1f97), /* Z60* (1) */
>  	TPACPI_Q_IBM('7', 'F', 0x1f97), /* Z61* (1) */
>  	TPACPI_Q_IBM('7', 'B', 0x1fb7), /* X60 (1) */
> +	
> +	TPACPI_Q_LNV('6', 'U', 0x4087), /* T410s */

Where did you get the values for id1 & id2? I ask as want to add it as a
useful led on the regular T410  .. which apparently doesn't have all the
exact same values here.

Acked-by: Jerone Young <jerone.young@xxxxxxxxxxxxx>


>  
>  	/* (1) - may have excess leds enabled on MSB */
>  



------------------------------------------------------------------------------
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux