On Fri, Jun 19, 2009 at 12:54:41PM +0200, Josip Rodin wrote:
> > I just booted into Linux again, it restored itself fine from hibernation,
> > but now I get a new symptom:
> >
> > % cat /sys/devices/platform/thinkpad_acpi/wwan_enable
> > 0
> > % sudo sh -c 'echo 1 > /sys/devices/platform/thinkpad_acpi/wwan_enable'
> > sh: line 0: echo: write error: Operation not permitted
> >
> > I need to recompile my kernel with thinkpad_acpi a module...
>
> Ohh, sorry, it was trivial - the hardware switch was off, so the software
> returned -EPERM. Here's another place where some printk'ing would be most
> appreciated by us poor users :)
The attached trivial patch would seem to be useful for this.
--
2. That which causes joy or happiness.
--- thinkpad_acpi.c~ 2009-06-10 05:05:27.000000000 +0200
+++ thinkpad_acpi.c 2009-06-19 13:02:40.000000000 +0200
@@ -3118,8 +3118,11 @@
/* WLSW overrides bluetooth in firmware/hardware, but there is no
* reason to risk weird behaviour. */
if (tp_features.hotkey_wlsw && !hotkey_get_wlsw(&status) && !status
- && radio_on)
+ && radio_on) {
+ printk(TPACPI_NOTICE
+ "RFKILL already disabled by hardware, sorry.\n");
return -EPERM;
+ }
vdbg_printk(TPACPI_DBG_RFKILL,
"will %s bluetooth\n", radio_on ? "enable" : "disable");
@@ -3427,8 +3430,11 @@
/* WLSW overrides bluetooth in firmware/hardware, but there is no
* reason to risk weird behaviour. */
if (tp_features.hotkey_wlsw && !hotkey_get_wlsw(&status) && !status
- && radio_on)
+ && radio_on) {
+ printk(TPACPI_NOTICE
+ "RFKILL already disabled by hardware, sorry.\n");
return -EPERM;
+}
vdbg_printk(TPACPI_DBG_RFKILL,
"will %s WWAN\n", radio_on ? "enable" : "disable");
@@ -3725,8 +3731,11 @@
/* WLSW overrides UWB in firmware/hardware, but there is no
* reason to risk weird behaviour. */
if (tp_features.hotkey_wlsw && !hotkey_get_wlsw(&status) && !status
- && radio_on)
+ && radio_on) {
+ printk(TPACPI_NOTICE
+ "RFKILL already disabled by hardware, sorry.\n");
return -EPERM;
+}
vdbg_printk(TPACPI_DBG_RFKILL,
"will %s UWB\n", radio_on ? "enable" : "disable");
------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
