On mer, 2008-10-01 at 22:43 -0400, Paride Legovini wrote: > And thats ok. And I get the hotkeys working! At a first sight even the > brightness control seems to work, BUT, if (and only if) I reach the > lowest level of brightness and I press the brightness-down key > combination once again I get TWO acpi events from acpi_listen: > > video LCD0 00000087 00000000 > ibm/hotkey HKEY 00000080 00005010 > > and the brightness control is messed up! Every change in brightness > takes a long time to occur (almost a second), and this is very > annoying. I get a double acpi event for every change in brightness, > UNLESS I press the key combination too fast. In this case only > the last event is double. Here's a series of brightness-up > events: I get/got the same kind of behavior on my T61 with X3100. Matthew Garrett once sent a patch for thinkpad-acpi to call some function in the DSDT which would fix the delay. I'm attaching it, it works fine on my tree, but It's a mix between linux-acpi-2.6/test and drm-2.6/drm-next, and maybe the patch requires the “opregion” patch from Matthew too. Cheers, -- Yves-Alexis
Date: Wed, 6 Aug 2008 07:34:41 +0100
From: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
To: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
Cc: Yves-Alexis Perez <corsac@xxxxxxxxxx>, airlied@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] Add Intel ACPI IGD OpRegion support
Message-ID: <20080806063441.GA14455@xxxxxxxxxxxxx>
References: <20080805183725.GA4468@xxxxxxxxxxxxx>
<1217965470.5449.4.camel@hidalgo> <1217972874.4540.3.camel@hidalgo>
<20080806001301.GA10630@xxxxxxxxxxxxx>
<20080806023247.GA4665@xxxxxxxxxxxxxxxxxxxxx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080806023247.GA4665@xxxxxxxxxxxxxxxxxxxxx>
User-Agent: Mutt/1.5.12-2006-07-14
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: mjg59@xxxxxxxxxxxx
X-SA-Exim-Scanned: No (on vavatch.codon.org.uk); SAEximRunCond expanded to
false
X-Evolution-Source: imap://corsac%40corsac.net@xxxxxxxxxxxxxxx/
Content-Transfer-Encoding: 8bit
On Tue, Aug 05, 2008 at 11:32:48PM -0300, Henrique de Moraes Holschuh wrote:
> On Wed, 06 Aug 2008, Matthew Garrett wrote:
> > The 750ms delay is from thinkpad-acpi. I sent a patch to Henrique which
> > makes it go away, but I'm not entirely sure what the ACPI method
> > concerned is supposed to be doing. The opregion code won't currently run
> > until X is started because the drm layer requires X to be the foreground
> > vt before handling IRQs.
>
> Well, for what is it worth, thinkpad-acpi has a knob (brightness_mode) which
> can be used. Set it to CMOS mode (see docs). From what I recall, it should
> do what your patch does.
It doesn't seem to, no. I should have been clearer - the delay is in the
DSDT (not thinkpad-acpi itself), but there's a Thinkpad-specific ACPI
call that seems to be needed in order to delay it. Here's the patch
again.
diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
index b596929..bbc45c8 100644
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -899,6 +899,9 @@ static int __init tpacpi_check_std_acpi_brightness_support(void)
if (ACPI_SUCCESS(status) && bcl_levels > 2) {
tp_features.bright_acpimode = 1;
+ /* Set ACPI mode */
+ if (!acpi_evalf(hkey_handle, NULL, "PWMS", "vd", 0))
+ printk(TPACPI_INFO "Failed to claim backlight\n");
return (bcl_levels - 2);
}
--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
