On Mon, Oct 15, 2007 at 06:45:53PM +0200, Thomas Renninger wrote: > + if (ACPI_SUCCESS(acpi_get_handle(handle, "_BCM", &h_dummy1)) && > + ACPI_SUCCESS(acpi_get_handle(handle, "_BCL", &h_dummy2)) && > + ACPI_SUCCESS(acpi_get_handle(handle, "_BQC", &h_dummy3))) > + acpi_video_support |= ACPI_VIDEO_BRIGHTNESS; Probably want to check for _BCQ as an alternative to _BQC as well. > + return 0; Why return int if you always return 0? Other than that, it looks reasonable (and saves us having copy and pasted code in all of the hardware-specific drivers) -- Matthew Garrett | mjg59@xxxxxxxxxxxxx ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
