On Tue, 29 May 2007, Richard Hughes wrote: > On Tue, 2007-05-29 at 22:11 +0100, Bastien Nocera wrote: > > > Please review, and make sure I'm on the right lines. I also can't > > see > > > the input patches in the ibm-acpi-2.6 tree, so I've done this > > against > > > linus. This isn't for merging, it's just a preview for comments. > > Why is defining a _new_ device with its own mixer a good idea? Isn't > > it actually supposed to be a track in the builtin ALSA device instead? > > And then we'd get feedback from that one... > > It is a _physically_ separate mixer - i.e. independent from the built-in > ALSA device. It's just unusual hardware. Also IMO it would be impossible > to link the nvram polling with another master volume on the main mixer > in the thinkpad_acpi code. And it also has weird behaviour if you have sound taps in weird places, e.g. the ones in port replicators for the T4x series. They are not under control of the thinkpad mixer, but they are under full control of the AC97 mixer. As Richard just said, it *really* is a separate device, and we shall export it as such. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel