On Mon, May 16, 2011 at 22:40, Nix <nix@xxxxxxxxxxxxx> wrote:
> On 16 May 2011, Kay Sievers stated:
>
>> Commited a fix to git, that moves the creation of the queue file above
>> the daemonize. Hopefully that's the race you are seeing.
>
> Hm, not done more than compile it yet, but there's definitely still
> something wrong here: it coredumps if called with invalid arguments.
> --- a/libudev/libudev-queue-private.c
> +++ b/libudev/libudev-queue-private.c
> @@ -104,6 +104,9 @@ void udev_queue_export_cleanup(struct udev_queue_export *udev_queue_export)
> Â{
> Â Â Â Âchar filename[UTIL_PATH_SIZE];
>
> + Â Â Â if (udev_queue_export == NULL)
> + Â Â Â Â Â Â Â return;
> +
Committed.
> --- a/udev/udevd.c
> +++ b/udev/udevd.c
> @@ -69,7 +69,7 @@ static void log_fn(struct udev *udev, int priority,
> Â}
>
> Âstatic struct udev_rules *rules;
> -static struct udev_queue_export *udev_queue_export;
> +static struct udev_queue_export *udev_queue_export = NULL;
That's not needed for static vars.
Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
