Hi, (please keep me Cc'd, I'm not subscribed) following existing practice I wanted to add a quirk for the hotkeys of the Samsung N130 in the same way as it was done for the NC10, but was informed that this method is no longer accepted since the quirk can be handled in userspace using the force_release sysfs attribute introduced in 2.6.32-rc. http://lkml.org/lkml/2009/11/16/243 Usually it is /sys/devices/platform/i8042/serio0/force_release, with keycodes in decimal. The default is "369-370" (HANGEUL + HANJA keys). The correct value for N130 would be "130-132,134,136-137,179,247,249,369-370". (If I just add N130 to the regex in the NC10 line in /lib/udev/rules.d/95-keymap.rules, pressing some of the hotkeys generates an endless stream of key events which causes the keyboard to go dead in X. It can be brought back to life by switching to a Linux console with Ctrl-Alt-F1 and back.) I guess it would make sense to add support for the forced release attribute into extras/keymap/keymap.c in such a way that the keymap files (e.g. samsung-other) can have an optional third column with flags. Since many models share samsung-other, but only three had the force_release handled in to the kernel I'd also add a flag to keymap.c so that the forced_release flag is only applied when the --force-release/-f switch is present. The we can add two lines to 95-keymap.rules, one for models which need the quirk and one fo the others. On an older kernel which doesn't support the force_release sysfs attribute the flag would be silently ignored. Entries in samsung-other would then look like this: 0x82 switchvideomode force_release # Fn+F4 CRT/LCD (high keycode: "displaytoggle") 0x83 battery force_release,some_other_flag # Fn+F2 0x84 prog1 # Fn+F5 backlight on/off (if there is a need for some_other_flag in the future) Comments? Should I go forward and try to implement it? Thanks Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
