On Tue, Nov 10, 2009 at 00:13, Karel Zak <kzak@xxxxxxxxxx> wrote: > On Mon, Nov 09, 2009 at 03:19:09PM +0100, Marco d'Itri wrote: >> On Nov 09, Kay Sievers <kay.sievers@xxxxxxxx> wrote: >> >> > On Mon, Nov 9, 2009 at 04:46, Marco d'Itri <md@xxxxxxxx> wrote: >> > > These are needed to support out of tree builds, >> > Why isn't "make distcheck" failing then? >> Did you try it with a read only source tree? > > Yes, be careful with "make distcheck", it does not check for all > problems. Don't forget that "make distcheck" works with > source code from tarball and for example gtk-doc by default add many > generated files to the tarball. The best test is: > > git clean -xfd > ./autogen.sh > mkdir -p ../build > cd ../build > ./configure > make > > .. and try "ls -la ../udev/libudev/docs/ | wc -l" before and after the > make command :-) Yeah, I guess, that stuff is supposed to get DIST'd in the tarball, and should usually not be touched there during build. Running split builds directly from the git tree might not make much sense with gtk-doc. >> > Hmm, that looks a bit too weird, doesn't it? >> > > +srcdir := $(builddir) >> Maybe, but without something like that the building process will create >> files in the source tree. >> Ubuntu uses a similar workaround, this is a known gtk-doc bug. > > :-( > > The number of non-gtk libraries is slowly growing. It would be nice > to found a real solution... fix gtk-doc or found something better > than gtk-doc. Yeah, there is a lot of stuff that would be nice to see fixed, also many of the warnings of the generated code and the over-verbose output during the build. Kay -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
