[PATCH] scsi_id: prevent buffer overflow in check_fill_0x83_prespc3()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



see https://bugzilla.redhat.com/show_bug.cgi?id=516920
---
 extras/scsi_id/scsi_serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/extras/scsi_id/scsi_serial.c b/extras/scsi_id/scsi_serial.c
index 9235912..c456507 100644
--- a/extras/scsi_id/scsi_serial.c
+++ b/extras/scsi_id/scsi_serial.c
@@ -582,7 +582,7 @@ static int check_fill_0x83_prespc3(struct udev *udev,
 		serial[j++] = hex_str[(page_83[4+i] & 0xf0) >> 4];
 		serial[j++] = hex_str[ page_83[4+i] & 0x0f];
 	}
-	strcpy(serial_short, serial);
+	strncpy(serial_short, serial, max_len-1);
 	return 0;
 }
 
-- 
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux