Re: [PATCH] fix buffer overflow in util_run_program()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> > Now, what am I missing? I obviously do not understand much of how udev
> > works, but if the code of this function is not somewhat pointless, then
> > how would there not be a potential buffer overflow?
> >
> > Florian
> 
> Running "ls  -l" (two spaces) should be equivalent to "ls -l" (one
> space).  arg filled with spaces should be more or less equivalent to
> arg = "".  If it's not - then that's the real bug.

well, I don't want to get into fixing semantic bugs, as there generally
doesn't seem to be much of a hint as to what the intended semantics are -
except that you wonder how the code's semantics could actually be
intentional. So I would suggest fixing the buffer overflow for now, until
someone feels like taking care of the semantic bug.

Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux