Re: [PATCH] fix buffer overflow in util_run_program()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> > diff --git a/libudev/libudev-util-private.c
> >  b/libudev/libudev-util-private.c index 64203a8..c309945 100644
> > --- a/libudev/libudev-util-private.c
> > +++ b/libudev/libudev-util-private.c
> > @@ -268,7 +268,7 @@ int util_run_program(struct udev *udev, const
> >  char *command, char **envp, pid_t pid;
> >  	char arg[UTIL_PATH_SIZE];
> >  	char program[UTIL_PATH_SIZE];
> > -	char *argv[(sizeof(arg) / 2) + 1];
> > +	char *argv[sizeof(arg) + 1];
> 
> Could you give example when this overflows?

UTIL_PATH_SIZE-1 spaces.

Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux