On Thu, Jun 11, 2009 at 18:13, Mario
Limonciello<mario_limonciello@xxxxxxxx> wrote:
> Thanks for the feedback. I've made the changes and am resubmitting.
This is all about adding USB devices, right? So the entire rules file
should be guarded by:
ACTION=="add", ... out
SUBSYSTEM=="usb", ... out
ENV{DEVTYPE}=="usb_device", ... out
to exclude all other events from trying to match these rules. Also the
individual ACTION matches are not needed then.
+ ... ENV{ID_CLASS}=="mouse", ..., KERNEL=="mouse*", ...
I think the kernel name match is sufficient here, there is no need to
rely on earlier rules which set ID_CLASS.
+ ... ENV{ID_VENDOR}=="046d",
This is a property of usb_id, and usually a textual string and not a
number, I guess you better match against the sysfs attribute with
ATTR{}? The current stuff might work, but you should not rely on the
implicit fallback to numbers of usb_id.
+ RUN+="/lib/udev/hid2hci ..."
Things in /lib/udev don't need the prefix, just use RUN+="hid2hci ..."
Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
