On Sat, Oct 25, 2008 at 18:42, Kay Sievers <kay.sievers@xxxxxxxx> wrote: > On Sat, Oct 25, 2008 at 18:01, Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx> wrote: >> udevd: Use a tighter loop for compare_devpath() >> >> This crops up in my threaded udevd profiles from time to time. >> It's not consistent - probably due to variations in the number >> of concurrent events - but it can hit 4% user time and higher. > > Yeah, I've seen that too some times. Nice! Applied. I've merged the udevd exec and run queue now to have always a sorted list. We remember the seqnum of the last event that caused an event to be delayed. Next time we need to check, we do not do the devpath string compare for all the events that we already checked in the earlier run. This saves us ~70% of the calls to compare_devpath(). Kay -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
