On Fri, Oct 17, 2008 at 10:49 AM, Alan Jenkins
<alan-jenkins@xxxxxxxxxxxxxx> wrote:
> Kay Sievers wrote:
>> On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
>> Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
>> event environment is replaced by a per-device property list. The
>> daemon, and everything else uses the libudev code now.
>>
>> It seems to work fine here, but the code may be a bit rough at the
>> moment, until it has seen more testing. But, it should be pretty easy
>> now to play around with a threaded version of the daemon.
> Great. I don't have so much time now though; I need to concentrate on
> project work.
>
> Going back to the original subject line... :-). I see the tests still
> pass, but some of them make suspicious noises now.
>
> TEST 7: label test of max sysfs files
> device
> '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
> expecting node 'boot_disk1'
> libudev: add_rule_key_pair: skip, too many keys of the same type in a single rule
That's valid, we ignore that rule. Added note to the test description.
> TEST 19: Handle stupid backslashed multi lines in config file (and replace kernel name)
> device '/devices/pci0000:00/0000:00:1d.7/usb5/5-2/5-2:1.0/tty/ttyACM0'
> expecting node 'modem'
> libudev: add_to_rules: invalid rule
We do not support backslash backslash, only backslash newline, I
removed the second backslash one from the test.
> TEST 118: ENV{} test (assign2)
> device
> '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
> expecting node 'part'
> libudev: add_to_rules: invalid rule
A rule with just unconditionally NAME= is invalid in the current
logic, it's from the time before we had GOTO. :) I've added a
SUBSYSTEM== match.
> TEST 129: final assignment
> device '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
> expecting node 'ok'
> libudev: lookup_group: specified group 'nobody'
Your system does not have group "nobody", I changed it to "tty".
> TEST 144: overlong comment line
> device '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
> expecting node 'yes'
> libudev: add_to_rules: invalid KERNEL operation
KERNEL="" can not work, it can only be matched. Fixed in the test.
> TEST 146: TEST absolute path
> device '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
> expecting node 'there'
> libudev: add_to_rules: invalid rule
Same as 118, I removed the NAME= only rule, and added a new test which
will just cover this case.
Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
